Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] app crashes when attempting to play a second video while another is playing #88

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[BUG] app crashes when attempting to play a second video while another is playing #88

wants to merge 5 commits into from
+566 −481

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Adds check if background service is running before attempting to bind it to activity
  • Adds warning message in Android for when above happens
  • Adds comments explaining why not to do this

Why is this Pull Request needed?

  • Fatal crash thrown when developer has two players with background audio enabled (this is not a valid use case in the current configuration)

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner October 8, 2024 20:02
edougher
edougher approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@edougher edougher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

edougher
edougher approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@edougher edougher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edougher edougher edougher approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @edougher